Skip to content

fix(SelectObject): should not override IsRequired method #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix(SelectObject): should not override IsRequired method #5464

merged 2 commits into from
Feb 28, 2025
+1 −13

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 28, 2025 •
edited by sourcery-ai bot
Loading

should not override IsRequired method

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5461

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where the IsRequired method was being overridden in SelectObject and SelectTable components, which was causing validation to not work correctly.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 28, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request removes the overriding of the IsRequired method in the SelectObject and SelectTable components. This resolves issue #5461.

Updated class diagram for SelectObject component

classDiagram
  class SelectObject {
    -ClearIcon : string
    -ValidateForm : object
    +OnParametersSet()
    +GetClearable() : bool
  }
Loading

Updated class diagram for SelectTable component

classDiagram
  class SelectTable {
    -ClearIcon : string
    -ValidateForm : object
    +OnParametersSet()
    +GetClearable() : bool
    +GetText() : string
  }
Loading

File-Level Changes

Change Details Files
Removed the override of the IsRequired method in SelectObject and SelectTable components.
  • Removed the IsRequired method override from SelectObject.razor.cs.
  • Removed the IsRequired method override from SelectTable.razor.cs.
 src/BootstrapBlazor/Components/Select/SelectObject.razor.cs
src/BootstrapBlazor/Components/Select/SelectTable.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5461 The SelectObject component should not display a required asterisk when the Required attribute is not set. ✅
#5461 The SelectTable component should not display a required asterisk when the Required attribute is not set. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Feb 28, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 28, 2025
sourcery-ai[bot]
sourcery-ai bot approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This looks like a good cleanup, removing unnecessary overrides.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) February 28, 2025 07:38
@codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ac2ac31) to head (472cb6c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #5464   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          646       646           
  Lines        29358     29356    -2     
  Branches      4131      4131           
=========================================
- Hits         29358     29356    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 8043e4e into main Feb 28, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-select branch February 28, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

v9.3.0

Development

Successfully merging this pull request may close these issues.

bug(SelectObject): 未设置Required时仍然出现必填*号

2 participants

@ArgoZhang